Added fillDescriptions to more classes in FWCore

[Dr15Jones]

PR description:

Used co-pilot to do initial changes.

PR validation:

Code compiles. Framework unit tests pass after fixing some which were passing incorrect parameters.

resolves cms-sw/framework-team#1780

[Dr15Jones]

please test

[cmsbuild]

cms-bot internal usage

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49765/47357

• There are other open Pull requests which might conflict with changes you have proposed:
  • File FWCore/Framework/test/stubs/ToyAnalyzers.cc modified in PR(s): [RFC] descriptions.addDefault -> descriptions.addWithDefaultLabel #44372

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49765/47357/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49765/47357/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[Dr15Jones]

please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49765/47359

• There are other open Pull requests which might conflict with changes you have proposed:
  • File FWCore/Framework/test/stubs/ToyAnalyzers.cc modified in PR(s): [RFC] descriptions.addDefault -> descriptions.addWithDefaultLabel #44372

[cmsbuild]

A new Pull Request was created by @Dr15Jones for master.

It involves the following packages:

• FWCore/Framework (core)
• FWCore/Integration (core)
• FWCore/Modules (core)
• FWCore/PythonFramework (core)
• FWCore/Services (core)
• FWStorage/Services (core)
• IOPool/Input (core)
• IOPool/Streamer (core)

@Dr15Jones, @makortel, @smuzaffar can you please review it and eventually sign? Thanks.
@fwyzard, @makortel, @missirol, @mmusich, @wddgit this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+1

Size: This PR adds an extra 76KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-60dfd4/50507/summary.html
COMMIT: ea1d933
CMSSW: CMSSW_16_1_X_2026-01-11-0000/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/49765/50507/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

The workflows 2025.0010001, 2024.0050001, 2023.0020001 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

Summary:

• You potentially added 14 lines to the logs
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 8010 differences found in the comparisons
• Reco comparison had 2 failed jobs
• DQMHistoTests: Total files compared: 53
• DQMHistoTests: Total histograms compared: 4071839
• DQMHistoTests: Total failures: 5159
• DQMHistoTests: Total nulls: 83
• DQMHistoTests: Total successes: 4066577
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -20.976 KiB( 51 files compared)
• DQMHistoSizes: changed ( 2023.0020001 ): -20.484 KiB Hcal/DigiRunHarvesting
• DQMHistoSizes: changed ( 2023.0020001 ): -0.539 KiB RPC/DCSInfo
• DQMHistoSizes: changed ( 2023.0020001 ): 0.043 KiB JetMET/SUSYDQM
• DQMHistoSizes: changed ( 2023.0020001 ): 0.005 KiB SiStrip/MechanicalView
• Checked 227 log files, 198 edm output root files, 53 DQM output files
• TriggerResults: no differences found

[Martin-Grunewald]

Why is it here and below all addDefault as opposed to addWithDefaultLabel ?

[Dr15Jones]

Because the I personally recommends not using addWithDefaultLabel, especially in cases where there is no useful default (which is very much the case for many of the test modules).