Assert that previously significant run stays significant #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some cases, runs which have been deemed significant, based on OMS data that RR receives, suddenly become non-significant on run update, due to data that has been removed or changed from the OMS side. This should not, in principle, happen. This commit adds such an assertion to throw an Exception if this case arises. Without it, the code continues, and in most cases reaches the point where RR tries to delete data from its database (usually LS info), raising an error (`Lumisections cannot be deleted`). The assertion catches this a bit earlier, stopping with a more appropriate message. This is probably not ideal, and this check could be placed even earlier.
nothingface0
force-pushed
the
assert_if_run_is_suddenly_non_significant
branch
from
a9cd483 to
8576d12
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases, runs which have been deemed significant, based on OMS data that RR receives, suddenly become non-significant after an update, due to data that has been removed or changed from the OMS side. This should, in principle, not happen.
This commit adds such an assertion to throw an Exception if this case arises. Without it, the code continues, and in most cases reaches the point where RR tries to delete data from its database (usually LS info), raising an error (
Lumisections cannot be deleted). The assertion catches this a bit earlier, stopping with a more appropriate message.This is probably not ideal, and this check could be placed even earlier.