-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vagrant + packer #2838
Vagrant + packer #2838
Conversation
@daxgames This is really cool and a great feature, but I was wondering whether instead of merging this branch into the master, we could use GH actions to sync it with the master, so that we can build the Vagrant releases from this branch directly? That way, we can avoid adding unnecessary files to the master branch for users/developers who don't use Vagrant. This way we can have a Users can also still use it by cloning the repo and checking out the branch. The only downside is that they need to clone the project for this, rather than downloading a ZIP source code snapshot (due to missing other branches). Still, we can provide that as a downloadable archive, as well. Otherwise (if you don't agree with this) we can go ahead and merge this PR as is. |
@DRSDavidSoft Does not really matter to me, but my thought process is below. I tried to set this up so that the zipped releases would not contain MOST of the packer/vagrant stuff. The only new files that would be included in the release are the scripts to integrate Cmder into other terminal emulators that are also used by the vagrant/packer processes. I am not sure I tried packaging it up, but I think it's right. If not, I can take another look. I considered making it a completely separate repo, but I thought the scripts mentioned above could be useful to other users. |
I'm sure the scripts for integrating into other terminals are useful, but I think it's better to directly commit them into master instead of merging through this branch. That way, we can introduce a couple of other PowerShell scripts as well that were proposed before (some are present in Shark, a fork of Cmder). So I agree with you on this point. Personally I was working on a tweaker script to customize the prompt and the background and foreground colors for ConEmu and Windows Terminal, so maybe we could've merged it in master. On a sidenote, would you mind if we merge our efforts so that the integration scripts you wrote and some that I was preparing would be merged in Lastly, I saw the gitignore and packingore patches and you are right about the build .zip files, but the new scripts will be present in the source .zip snapshots and any clone of the repo, which was what I was initially referring to. In any case, thanks for developing this and definitely a good job. Sorry if I made any mistakes as I'm on mobile and haven't gotten some proper sleep for the past week, I'll most definitely take an in-depth review so we can merge this PR sooner. I apologize for the delay in responses, thanks again for the new features 👍🏻 |
development dax
* upstream/development: enable `match.expand_envvars` fix: fix some typos in comments Bump softprops/action-gh-release from 1 to 2 Bump microsoft/setup-msbuild from 1 to 2 (cmderdev#2917) Bump peter-evans/create-pull-request from 5 to 6 (cmderdev#2918) Bump actions/upload-artifact from 3 to 4 (cmderdev#2905) Do CI on development PRs Bump github/codeql-action from 2 to 3 (cmderdev#2906)
Vagrant and Packer Templates for Cmder development VMs.
Usage:
Clone Cmder repo to local, checkout this branch, if not yet merged.
Install Oracle VM Virtualbox
Install Vagrant
Install Packer if you want to do Packer template development.4.
Windows
Linux
Add Vagrant boxes
vagrant box add dgames\cmderdev-10
vagrant box add dgames\cmderdev-11
Bring up a box.
vagrant up cmderdev-10
vagrant up cmderdev-11
Enjoy!
What this is.
Automation to build Packer VM Images for use with Vagrant to stand up ready to use Windows VMs for Cmder Development and Testing.
Tested Virtualbox Only
Un-Tested Hypervisors
All VMs Stood up with Vagrant Include
https://github.com/cmderdev/cmder
intoc:\Users\Vagrant\cmderdev
upstream
remote set tohttps://github.com/cmderdev/cmder
Post
vagrant up
ConfigSet your Cmder origin remote:
Packer Support Origins
Most of the Packer support for Cmder is shamelessly being borrowed from the following repositories and added to to support Cmder..
Thank you both for the good work!
Screenshots
Windows 10 - After
vagrant up
Windows 11 - With Post
vagrant up
user configuration.