Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support shutting down storage factory #724

Merged

Conversation

learner0810
Copy link
Contributor

@learner0810 learner0810 commented Jan 24, 2025

What type of PR is this?

/kind feature

What this PR does / why we need it:

When Clusterpedia pods are removed, the created storage factory will be shut down.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@clusterpedia-bot
Copy link

Hi @learner0810,
Thanks for your pull request!
If the PR is ready, use the /auto-cc command to assign Reviewer to Review.
We will review it shortly.

Details

Instructions for interacting with me using comments are available here.
If you have questions or suggestions related to my behavior, please file an issue against the gh-ci-bot repository.

@clusterpedia-bot clusterpedia-bot added the kind/feature New feature label Jan 24, 2025
@learner0810 learner0810 force-pushed the support-close-storage-factory branch from 91620e4 to d41a967 Compare January 24, 2025 03:29
Signed-off-by: learner0810 <zhongjun.li@daocloud.io>
@learner0810 learner0810 force-pushed the support-close-storage-factory branch from d41a967 to 54f27bc Compare January 24, 2025 03:34
@learner0810
Copy link
Contributor Author

/auto-cc

Copy link
Member

@Iceber Iceber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Iceber Iceber merged commit 80faec0 into clusterpedia-io:main Feb 5, 2025
6 of 7 checks passed
@learner0810 learner0810 deleted the support-close-storage-factory branch February 5, 2025 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants