Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix the issue which the server-side did not report failure after panic occurred during request processing #1655

Merged
merged 2 commits into from
Jan 6, 2025

Conversation

YangruiEmma
Copy link
Member

@YangruiEmma YangruiEmma commented Jan 2, 2025

What type of PR is this?

fix

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

zh: 修复服务端在请求处理发生panic后,结果未上报失败的问题

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en:
zh(optional):

(Optional) Which issue(s) this PR fixes:

(optional) The PR that updates user documentation:

@YangruiEmma YangruiEmma requested review from a team as code owners January 2, 2025 02:37
@YangruiEmma YangruiEmma changed the title fix: fix the issue which the server-side did not report failure after… fix: fix the issue which the server-side did not report failure after panic occurred during request processing Jan 2, 2025
@YangruiEmma YangruiEmma force-pushed the fix/read_panic branch 4 times, most recently from fe8890e to 3a9d564 Compare January 4, 2025 15:32
@YangruiEmma YangruiEmma merged commit c1caae0 into cloudwego:develop Jan 6, 2025
19 checks passed
@xiaost xiaost mentioned this pull request Feb 12, 2025
3 tasks
HeyJavaBean pushed a commit to HeyJavaBean/kitex that referenced this pull request Feb 13, 2025
HeyJavaBean pushed a commit to HeyJavaBean/kitex that referenced this pull request Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants