fix: fix the issue which the server-side did not report failure after panic occurred during request processing #1655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YangruiEmma
changed the title
YangruiEmma
force-pushed
the
fix/read_panic
branch
from
2dc500e to
1a6b385
Compare
jayantxie
reviewed
Jan 2, 2025
ppzqh
reviewed
Jan 2, 2025
ppzqh
reviewed
Jan 2, 2025
YangruiEmma
force-pushed
the
fix/read_panic
branch
4 times, most recently
from
fe8890e to
3a9d564
Compare
… a panic occurred during request processing
YangruiEmma
force-pushed
the
fix/read_panic
branch
from
3a9d564 to
8a6cebe
Compare
… a panic occurred during request processing
jayantxie
approved these changes
Jan 6, 2025
ppzqh
approved these changes
Jan 6, 2025
3 tasks
HeyJavaBean
pushed a commit
to HeyJavaBean/kitex
that referenced
this pull request
Feb 13, 2025
… panic occurred during request processing (cloudwego#1655)
HeyJavaBean
pushed a commit
to HeyJavaBean/kitex
that referenced
this pull request
Feb 21, 2025
… panic occurred during request processing (cloudwego#1655)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
fix
Check the PR title.
(Optional) Translate the PR title into Chinese.
zh: 修复服务端在请求处理发生panic后，结果未上报失败的问题
(Optional) More detailed description for this PR(en: English/zh: Chinese).
en:
zh(optional):
(Optional) Which issue(s) this PR fixes:
(optional) The PR that updates user documentation: