fix:(generic) avoid over-boundary pointer #86
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jayantxie
approved these changes
Feb 12, 2025
|
|
||
| func PtrOffset(a unsafe.Pointer, b unsafe.Pointer) int { | ||
| func PtrOffset(a uintptr, b uintptr) int { | ||
| return int(uintptr(a)) - int(uintptr(b)) |
Contributor
There was a problem hiding this comment.
Why did you change the arguments from unsafe.Pointer to uintptr?
And if you use uintptr, why don't you just return int(a) - int(b)?
Collaborator
Author
There was a problem hiding this comment.
in case of bad pointer pass to this func. Actually can pass int, just too lazy to change old codes
khan-yin
pushed a commit
to khan-yin/dynamicgo
that referenced
this pull request
Apr 26, 2025
* fix:(generic) avoid over-boundary pointer * fix:(generic) avoid over-boundary pointer * update ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
fix
Check the PR title.
(Optional) Translate the PR title into Chinese.
(Optional) More detailed description for this PR(en: English/zh: Chinese).
en: rt.AddPtr(node.v, node.l) will cause over-boundary pointer. fix
bad pointerGC problemzh(optional):
(Optional) Which issue(s) this PR fixes:
(optional) The PR that updates user documentation: