chore: Left drawer visual updates #3815
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3815 +/- ##
=======================================
Coverage 97.10% 97.10%
=======================================
Files 840 840
Lines 24472 24472
Branches 8637 8636 -1
=======================================
Hits 23763 23763
- Misses 659 702 +43
+ Partials 50 7 -43 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
georgylobko
force-pushed
the
chore/left-drawer-visual-upd
branch
from
56e2ecf to
ede2fb9
Compare
georgylobko
force-pushed
the
chore/left-drawer-visual-upd
branch
from
97ec42f to
e1e1f8a
Compare
georgylobko
requested review from
gethinwebster and
just-boris
and removed request for
a team
just-boris
reviewed
Aug 29, 2025
There was a problem hiding this comment.
Looks good overall, but I still recommend to wait for @gethinwebster review, because this is now everyones' feature, not just our squad's
| @@ -47,4 +47,5 @@ export const tokens: StyleDictionary.BordersDictionary = { | |||
| borderWidthField: '1px', | |||
| borderWidthPopover: '2px', | |||
| borderWidthToken: '2px', | |||
| borderAiPanelWidth: '2px', | |||
There was a problem hiding this comment.
Why did you move it here? Do we expect it to be themed or anything?
There was a problem hiding this comment.
No, I don't expect to reuse it anywhere. Removed
georgylobko
force-pushed
the
chore/left-drawer-visual-upd
branch
from
bed5fd6 to
036a603
Compare
just-boris
reviewed
Aug 29, 2025
| @@ -951,7 +951,8 @@ export type ShadowsTokenName = | |||
| | 'shadowSticky' | |||
| | 'shadowStickyEmbedded' | |||
| | 'shadowStickyColumnFirst' | |||
| | 'shadowStickyColumnLast'; | |||
| | 'shadowStickyColumnLast' | |||
| | 'borderAiPanelWidth'; | |||
There was a problem hiding this comment.
need to remove this too
Suggested change
| | 'borderAiPanelWidth'; |
georgylobko
force-pushed
the
chore/left-drawer-visual-upd
branch
from
01d8114 to
0d6f13e
Compare
gethinwebster
approved these changes
Sep 1, 2025
pranshuteotia
pushed a commit
to pranshuteotia/components
that referenced
this pull request
Sep 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR includes visual updates for the left global panel in accordance with the design bug bash (q
MzUMAouvFuAa)Related links, issue #, if available: n/a
How has this been tested?
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.