chore: Add missing instanceIdentifier to ExpandableSection #3215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3215 +/- ##
========================================
Coverage 96.44% 96.44%
========================================
Files 790 790
Lines 22246 22249 +3
Branches 7575 7231 -344
========================================
+ Hits 21455 21458 +3
- Misses 739 784 +45
+ Partials 52 7 -45 ☔ View full report in Codecov by Sentry. |
michaeldowseza
force-pushed
the
analytics/expandable-section
branch
from
eb05546 to
5f8fae2
Compare
michaeldowseza
commented
Jan 24, 2025
| const analyticsComponentMetadata: GeneratedAnalyticsMetadataExpandableSectionComponent = { | ||
| name: 'awsui.ExpandableSection', | ||
| label: { root: 'self' }, | ||
| properties: { variant, expanded: `${!!expanded}` }, | ||
| }; | ||
|
|
||
| console.log(analyticsMetadata); |
michaeldowseza
force-pushed
the
analytics/expandable-section
branch
from
7d2cb29 to
dbd29e3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Correctly pass down the analytics Metadata props to the container variant of the expandable section.
Related links, issue #, if available: n/a
How has this been tested?
Added usage of Expandable Section to integ test page and added integ test for the metadata property.
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.