Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Public layout component #3208

Draft
wants to merge 20 commits into
base: main
Choose a base branch
from
Draft

Conversation

georgylobko
Copy link
Contributor

@georgylobko georgylobko commented Jan 21, 2025

Description

doc: tb1MA6m8ZZEt

Related links, issue #, if available: n/a

How has this been tested?

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

codecov bot commented Jan 21, 2025

Codecov Report

Attention: Patch coverage is 98.03922% with 1 line in your changes missing coverage. Please review.

Project coverage is 96.44%. Comparing base (e1c488b) to head (ff8c5d0).

Files with missing lines Patch % Lines
src/page-layout/index.tsx 97.43% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##             main    #3208    +/-   ##
========================================
  Coverage   96.44%   96.44%            
========================================
  Files         790      792     +2     
  Lines       22246    22292    +46     
  Branches     7644     7251   -393     
========================================
+ Hits        21455    21500    +45     
- Misses        739      785    +46     
+ Partials       52        7    -45     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These styles were copied from pages/app-layout

…mponent

# Conflicts:
#	src/__tests__/snapshot-tests/__snapshots__/test-utils-wrappers.test.tsx.snap
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant