fix: Allow text selection in date picker and date range picker #3181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3181 +/- ##
========================================
Coverage 96.40% 96.41%
========================================
Files 784 784
Lines 22144 22142 -2
Branches 7191 7594 +403
========================================
- Hits 21349 21348 -1
+ Misses 788 787 -1
Partials 7 7 ☔ View full report in Codecov by Sentry. |
jperals
commented
Jan 10, 2025
| @@ -168,11 +168,6 @@ const DatePicker = React.forwardRef( | |||
|
|
|||
| baseProps.className = clsx(baseProps.className, styles.root, styles['date-picker-container']); | |||
|
|
|||
| const handleMouseDown = (event: React.MouseEvent) => { | |||
There was a problem hiding this comment.
This was preventing text selection in date picker even after removing user-select: none from the dropdown.
It was introduced 3.5 years ago in CR-49510605 with the justification to prevent an undesired focus ring from appearing when clicking the calendar, but I can't reproduce this today.
jperals
commented
Jan 10, 2025
| @@ -131,7 +131,6 @@ $calendar-header-color: awsui.$color-text-body-default; | |||
| } | |||
|
|
|||
| .label { | |||
| user-select: text; | |||
There was a problem hiding this comment.
These two rules to override the parent's behavior are not necessary anymore
jperals
changed the title
jperals
changed the title
2 tasks
pan-kot
approved these changes
Jan 15, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issue:
AWSUI-60182In the case of dropdowns that contain only a list of selectable options (autosuggest, button dropdown, multiselect, select) it makes sense to disable text selection, but not necessarily for anything that the dropdown may contain, and in particular not for date pickers and date range pickers, where this is having undesired side effects. Therefore moving
user-select: nonefrom the dropdown component down to the options list component.How has this been tested?
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.