Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Emit performance marks only for loaded components #3175

Merged
merged 3 commits into from
Jan 10, 2025

Conversation

guptbhum
Copy link
Contributor

@guptbhum guptbhum commented Jan 8, 2025

Description

Bug - {component}Rendered and {component}Updated marks are emitted even if current component is loading.
Fix - Updated the usePerformanceMarks logic to emit markers only after the components are fully loaded.

Related links, issue #, if available: n/a

How has this been tested?

Locally tested the change
Updated unit and integration tests

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests? existing tests
  • Changes are covered with new/existing integration tests? existing tests

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@guptbhum guptbhum requested a review from a team as a code owner January 8, 2025 16:57
@guptbhum guptbhum requested review from Al-Dani and removed request for a team January 8, 2025 16:57
@guptbhum guptbhum changed the title Performance bug fix fix: Emit performance marks only for loaded components Jan 8, 2025
Copy link

codecov bot commented Jan 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.40%. Comparing base (1f1d269) to head (c79323c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##             main    #3175    +/-   ##
========================================
  Coverage   96.40%   96.40%            
========================================
  Files         784      784            
  Lines       22143    22144     +1     
  Branches     7594     7191   -403     
========================================
+ Hits        21348    21349     +1     
  Misses        788      788            
  Partials        7        7            

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@abdhalees abdhalees added this pull request to the merge queue Jan 10, 2025
Merged via the queue into cloudscape-design:main with commit 67c06fa Jan 10, 2025
37 of 39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants