revert: Revert "fix: Move focus to the attribute editor add button even if currently disabled" #3062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rrently …" This reverts commit f1ff83f.
just-boris
approved these changes
Nov 26, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3062 +/- ##
==========================================
- Coverage 96.34% 96.34% -0.01%
==========================================
Files 780 780
Lines 21928 21927 -1
Branches 7503 7099 -404
==========================================
- Hits 21127 21126 -1
Misses 794 794
Partials 7 7 ☔ View full report in Codecov by Sentry. |
jperals
pushed a commit
that referenced
this pull request
Dec 2, 2024
…en if currently disabled" (#3062)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #3035. Looks like we have tests that check for the add button to be disabled that I couldn't find with a code search after all. Reverting "pessimistically" to have a clean path to merge.
Looks like I'll have to go with a less ideal "queued" focus effect logic.