Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adds table progressive loading empty state #3037

Closed
wants to merge 1 commit into from

Conversation

pan-kot
Copy link
Member

@pan-kot pan-kot commented Nov 20, 2024

Description

Adds empty state to currently existing pending, loading, error, and finished states of the table progressive loading. That is to support async row expand that results in an empty array of nested items.

Rel: [yCGlAk8AlAO9]

How has this been tested?

  • Enhanced unit tests
  • Manual testing on the updated test page
  • Dry run to ensure no TS issues caused by the type extension
Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.34%. Comparing base (ad36547) to head (4b0114e).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3037   +/-   ##
=======================================
  Coverage   96.34%   96.34%           
=======================================
  Files         780      780           
  Lines       21927    21929    +2     
  Branches     7503     7503           
=======================================
+ Hits        21126    21128    +2     
- Misses        749      794   +45     
+ Partials       52        7   -45     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pan-kot
Copy link
Member Author

pan-kot commented Nov 28, 2024

Closed in favour of #3067

@pan-kot pan-kot closed this Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant