feat: inactive tab persistence for Tabs #2975
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 2, 2024 22:54
This commit adds an opt-in feature that causes all tabs contents to be created without regard to their active status, whereas only the active tab is being shown.
This commit adds an opt-in feature that causes all tabs contents to be created without regard to their active status, whereas only the active tab is being shown.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2975 +/- ##
==========================================
- Coverage 96.25% 95.70% -0.55%
==========================================
Files 768 768
Lines 21749 21751 +2
Branches 7034 7437 +403
==========================================
- Hits 20934 20817 -117
- Misses 807 926 +119
Partials 8 8 ☔ View full report in Codecov by Sentry. |
timogasda
reviewed
Nov 20, 2024
| @@ -74,9 +74,11 @@ export interface TabsProps extends BaseComponentProps { | |||
| */ | |||
| i18nStrings?: TabsProps.I18nStrings; | |||
| /** | |||
| * Enabling this property makes the tab content fit to the available height. | |||
| * If the tab content is too short, it will stretch. If the tab content is too long, a vertical scrollbar will be shown. | |||
There was a problem hiding this comment.
You've removed the description for fitHeight
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds an opt-in feature that causes all tabs contents to be created without regard to their active status, whereas only the active tab is being shown.
Description
Related links, issue #, if available: n/a
How has this been tested?
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.