Move conditional props to a single spreadable object

cloudscape-design · Dec 2, 2024 · 4eb02bf · 4eb02bf
1 parent 3761ab3
commit 4eb02bf
Showing 1 changed file with 4 additions and 5 deletions.
diff --git a/src/app-layout/visual-refresh-toolbar/toolbar/index.tsx b/src/app-layout/visual-refresh-toolbar/toolbar/index.tsx
@@ -166,6 +166,9 @@ export function AppLayoutToolbarImplementation({
   }, [anyPanelOpenInMobile]);
 
   const toolbarHidden = toolbarState === 'hide' && !pinnedToolbar;
+  const navLandmarkAttributes = navigationOpen
+    ? { role: 'presentation' }
+    : { role: 'navigation', 'aria-label': ariaLabels?.navigation };
 
   return (
     <ToolbarSlot
@@ -180,11 +183,7 @@ export function AppLayoutToolbarImplementation({
     >
       <div className={styles['toolbar-container']}>
         {hasNavigation && (
-          <nav
-            className={clsx(styles['universal-toolbar-nav'])}
-            role={navigationOpen ? 'presentation' : 'navigation'}
-            aria-label={navigationOpen ? undefined : ariaLabels?.navigation}
-          >
+          <nav {...navLandmarkAttributes} className={clsx(styles['universal-toolbar-nav'])}>
             <TriggerButton
               ariaLabel={ariaLabels?.navigationToggle ?? undefined}
               ariaExpanded={false}