chore: Experiment with simpler portal #13429
pan-kotbuild-lint-test.yml
on: pull_request
build
/
git-secrets
4s
build
/
build
6m 21s
build
/
codeql
2m 23s
deploy
/
deploy
Annotations
8 errors and 2 warnings
|
Portal › when a container is not provided › renders to a div under body:
src/internal/components/portal/__tests__/portal.test.tsx#L198
expect(received).toHaveTextContent()
received value must be a Node.
Received has value: null
at __EXTERNAL_MATCHER_TRAP__ (node_modules/expect/build/index.js:325:30)
at Object.throwingMatcher [as toHaveTextContent] (node_modules/expect/build/index.js:326:15)
at Object.<anonymous> (src/internal/components/portal/__tests__/portal.test.tsx:198:56)
|
|
Portal › when a container is not provided › removes container element when unmounted:
src/internal/components/portal/__tests__/portal.test.tsx#L204
expect(received).toBe(expected) // Object.is equality
Expected: 2
Received: 1
at Object.<anonymous> (src/internal/components/portal/__tests__/portal.test.tsx:204:62)
|
|
URL sanitization › for a utility button › does not throw an error when a safe javascript: URL is passed:
src/top-navigation/1.0-beta/__tests__/top-navigation-beta.test.tsx#L60
TypeError: Cannot read properties of null (reading 'findButtonLinkType')
at Object.<anonymous> (src/top-navigation/1.0-beta/__tests__/top-navigation-beta.test.tsx:60:37)
|
|
URL sanitization › for a utility menu item › does not throw an error when a safe javascript: URL is passed:
src/top-navigation/1.0-beta/__tests__/top-navigation-beta.test.tsx#L82
TypeError: Cannot read properties of null (reading 'findMenuDropdownType')
at Object.<anonymous> (src/top-navigation/1.0-beta/__tests__/top-navigation-beta.test.tsx:82:47)
|
|
URL sanitization › for a nested utility menu item › does not throw an error when a safe javascript: URL is passed:
src/top-navigation/1.0-beta/__tests__/top-navigation-beta.test.tsx#L128
TypeError: Cannot read properties of null (reading 'findMenuDropdownType')
at Object.<anonymous> (src/top-navigation/1.0-beta/__tests__/top-navigation-beta.test.tsx:128:47)
|
|
metadata get attached on the Portal component root DOM node when elementRef is changing:
src/internal/hooks/use-base-component/__tests__/use-base-component.test.tsx#L86
expect(received).toBeUndefined()
Received: {"name": "PortalDemoComponent", "version": "3.0.0 (e8c30708)"}
at Object.<anonymous> (src/internal/hooks/use-base-component/__tests__/use-base-component.test.tsx:86:58)
|
|
renders modal without crashing:
src/internal/components/portal/index.tsx#L66
ReferenceError: document is not defined
at document (src/internal/components/portal/index.tsx:66:33)
at processChild (node_modules/react-dom/cjs/react-dom-server.node.development.js:3043:14)
at resolve (node_modules/react-dom/cjs/react-dom-server.node.development.js:2960:5)
at ReactDOMServerRenderer.render (node_modules/react-dom/cjs/react-dom-server.node.development.js:3435:22)
at ReactDOMServerRenderer.read (node_modules/react-dom/cjs/react-dom-server.node.development.js:3373:29)
at renderToStaticMarkup (node_modules/react-dom/cjs/react-dom-server.node.development.js:4004:27)
at Object.<anonymous> (src/__tests__/functional-tests/ssr.test.ts:22:41)
|
|
build / build
Process completed with exit code 1.
|
|
build / git-secrets
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|
|
build / codeql
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|