Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert to TF 0.12. Add tests. Add Codefresh test pipeline #14

Merged
merged 2 commits into from
May 8, 2020
Merged

Convert to TF 0.12. Add tests. Add Codefresh test pipeline #14

merged 2 commits into from
May 8, 2020

Conversation

aknysh
Copy link
Member

@aknysh aknysh commented May 8, 2020 •
edited
Loading

what

  • Port module to Terraform 0.12
  • Pin all providers
  • Add example for testing
  • Add bats and terratest for the example
  • Add Codefresh badge to point to the test pipeline in terraform-modules project
  • Update README
  • Add slash-command-dispatch GitHub Action
  • Add Pull Request and Issue templates

why

  • Module currently does not work with 0.12. Much easier syntax
  • Better regression control
  • Automatically test the example on every commit and pull request
  • Provision resources on AWS in the test account and check the outputs for the correct values
  • terraform-modules project contains pipelines for all terraform modules

notes

related

@aknysh aknysh requested review from osterman and maximmi May 8, 2020 03:03
@aknysh aknysh self-assigned this May 8, 2020
@aknysh aknysh merged commit 39ede1c into master May 8, 2020
@aknysh aknysh deleted the terraform-0.12 branch May 8, 2020 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@osterman osterman osterman approved these changes

@maximmi maximmi Awaiting requested review from maximmi

Assignees

@aknysh aknysh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clean up TF 0.12 warnings ARN output
2 participants
@aknysh @osterman