Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(readme): add commas to example #177

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

Maxiboy441
Copy link

Add commas to the example to fix syntax error due to missing line break

what

  • Added commas to line 40, 41, 47, 48 of the example of usage in the README, each time after the name value

why

  • My Editor mentioned the syntax error and after terraform initit also complained about it with
    ╷ │ Error: Missing attribute separator │ │ on main.tf line 40, in module "rds_instance": │ 40: { name = "myisam_sort_buffer_size" value = "1048576" }, │ │ Expected a newline or comma to mark the beginning of the next attribute.
    so I added the commas it asked me for.

references

NoN

Add commas to the example to fix syntax error due to missing line break
@Maxiboy441 Maxiboy441 requested review from a team as code owners May 2, 2024 09:20
@mergify mergify bot added the triage Needs triage label May 2, 2024
@nitrocode nitrocode added the no-release Do not create a new release (wait for additional code changes) label Jun 3, 2024
@nitrocode nitrocode changed the title fix: add commas to example fix(readme): add commas to example Jun 3, 2024
nitrocode
nitrocode previously approved these changes Jun 3, 2024
@nitrocode
Copy link
Member

/terratest

@mergify mergify bot removed the triage Needs triage label Jun 3, 2024
@nitrocode nitrocode dismissed their stale review June 3, 2024 21:29

test failed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-release Do not create a new release (wait for additional code changes)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants