Fix EFS volume configuration getting discarded #284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/terratest |
|
@hans-d can we please terratest this, happy to try and get it ready for merge. Thanks! |
|
/terratest |
|
This looks good to me! If anyone wants to provide a second set of eyes, that would be appreciated @cloudposse/contributors |
|
Thanks @RoseSecurity for taking a look! |
kevcube
reviewed
Aug 18, 2024
kevcube
approved these changes
Aug 21, 2024
|
Thanks @kevcube .. How will this get merged ? Do I need to do something. Thanks |
sorry, was waiting for tests to pass and forgot about it. merged now! |
|
These changes were released in v2.1.4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a copy of #235 as I would like to get it merged and it needed rebasing