Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix EFS volume configuration getting discarded #235

Closed
wants to merge 2 commits into from
Closed

Fix EFS volume configuration getting discarded #235

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c460931
fix EFS volume configuration getting discarded
jean-francois-sa Jul 13, 2023
9136c86
Merge branch 'main' into main
kevcube Aug 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,8 @@ module "ecs_alb_service_task" {
subnet_ids = var.ecs_private_subnet_ids
container_port = var.container_port
nlb_container_port = var.nlb_container_port
docker_volumes = var.volumes
docker_volumes = [for volume in var.volumes : volume if length(volume.docker_volume_configuration) > 0]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These conditions might be better in the ecs alb service task module instead of here

https://github.com/cloudposse/terraform-aws-ecs-alb-service-task

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nitrocode Wouldn't that require the ecs alb service task module to be refactored to accept a generic volumes variable?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm i don't imagine there would be much of a refactoring. I'll defer to the @cloudposse/contributors if they have an opinion on it

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to move this to ecs alb service task if needed. Just let me know what needs to be done to get this fix merged please

efs_volumes = [for volume in var.volumes : volume if length(volume.efs_volume_configuration) > 0]
ecs_load_balancers = local.load_balancers
deployment_controller_type = var.deployment_controller_type
deployment_maximum_percent = var.deployment_maximum_percent
Expand Down