Passthough AMI ID list to dynamic-subnets module #892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why: We want to be able to specify a list of ami ids to use for the nat instance What: passthought that list, default is empty
mfuhrmeisterDM
force-pushed
the
turtle/AMI-IDS
branch
from
6683334 to
4ff447b
Compare
aknysh
reviewed
Nov 1, 2023
aknysh
requested changes
Nov 1, 2023
There was a problem hiding this comment.
@mfuhrmeisterDM thank you for the PR, please address the comment
Co-authored-by: Andriy Knysh <[email protected]>
its applied |
aknysh
approved these changes
Nov 1, 2023
goruha
pushed a commit
to cloudposse-terraform-components/aws-vpc
that referenced
this pull request
Nov 27, 2024
…m-aws-components#892) Co-authored-by: Andriy Knysh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
why
We want to be able to specify a list of ami ids to use for the nat instance(s)
what
passthought that list, default is empty