Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: aws-saml/okta-user should handle enable flag #890

Closed
wants to merge 1 commit into from
Closed

fix: aws-saml/okta-user should handle enable flag #890

wants to merge 1 commit into from

Conversation

dudymas
Copy link
Contributor

@dudymas dudymas commented Nov 1, 2023

what

  • make sure references to potentially disabled resources are handled

why

@dudymas dudymas requested review from a team as code owners November 1, 2023 00:20
Nuru
Nuru requested changes Nov 1, 2023
View reviewed changes
Copy link
Contributor

@Nuru Nuru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the module is not enabled, it should not create any resources (or use data sources). Fix aws_iam_policy etc.

@hans-d hans-d mentioned this pull request Nov 8, 2023
Merged
@hans-d
Copy link
Contributor

hans-d commented Nov 12, 2023

@dudymas seems to be fixed with #903

@dudymas
Copy link
Contributor Author

dudymas commented Mar 19, 2024

Closing as another PR fixed this

@dudymas dudymas closed this Mar 19, 2024
@dudymas dudymas deleted the fix/aws-saml/finish-supporting-enabled branch March 19, 2024 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nuru Nuru Nuru requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dudymas @hans-d @Nuru