Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Multi Region Clusters for ArgoCD #880

Merged
merged 3 commits into from
Oct 23, 2023
Merged

Conversation

milldr
Copy link
Member

@milldr milldr commented Oct 18, 2023

what

  • Added environment to saml_sso_providers input for eks/argocd

why

  • The saml_sso_providers is used to read the output of another component. The SSO implementation of that component requires manually adding a few SSM parameters, but those values can be reused across regions. Therefore we only need to deploy saml_sso_provider once per stage, and then specify which environment to read from (if in an alternate region).

references

  • n/a

@milldr milldr requested review from a team as code owners October 18, 2023 21:21
Copy link
Contributor

@bradj bradj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@milldr milldr merged commit 119624b into main Oct 23, 2023
3 checks passed
@milldr milldr deleted the multiregion-argocd-saml branch October 23, 2023 17:25
goruha pushed a commit to cloudposse-terraform-components/aws-eks-argocd that referenced this pull request Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants