Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

datadog-synthetics-private-location Kubernetes Namespace #879

Merged
merged 3 commits into from
Oct 23, 2023
Merged

datadog-synthetics-private-location Kubernetes Namespace #879

merged 3 commits into from
Oct 23, 2023

Conversation

milldr
Copy link
Member

@milldr milldr commented Oct 18, 2023

what

  • Fixed namespace issues with datadog-synthetics-private-location
  • Added a comment

why

  • The input for helm-release for a namespace is kubernetes_namespace, not namespace
  • Comment to explain that namespace is usually created with the eks/datadog-agent component, so we usually don't need to create it here.

references

@milldr milldr requested review from a team as code owners October 18, 2023 16:54
@milldr milldr enabled auto-merge (squash) October 18, 2023 17:00
bradj
bradj approved these changes Oct 23, 2023
View reviewed changes
Copy link
Contributor

@bradj bradj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@milldr milldr merged commit 70bff64 into main Oct 23, 2023
2 of 3 checks passed
@milldr milldr deleted the datadog-synthetics-private-location-namespace branch October 23, 2023 17:14
goruha pushed a commit to cloudposse-terraform-components/aws-datadog-synthetics-private-location that referenced this pull request Nov 27, 2024
@milldr
datadog-synthetics-private-location Kubernetes Namespace (cloudposs…
5189ed3 
…e/terraform-aws-components#879)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bradj bradj bradj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@milldr @bradj