chore: add instance_refresh, al2023 to github-runners #871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
milldr
previously approved these changes
Oct 12, 2023
Nuru
previously requested changes
Oct 12, 2023
There was a problem hiding this comment.
Do not ignore launch template version. If instance_refresh is true and launch_template_version = "$Latest", configure launch_template_version to use the latest_version attribute of the aws_launch_template resource.
Add the ability to set instance_refresh.triggers.
Set appropriate options for instance refresh for GitHub Runners, such as scale_in_protected_instances = "Refresh".
dudymas
changed the title
|
This looks like it's too stale and needs to be closed. Also, the runs-on component is a better fit for modern infra. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
instance_refreshandlaunch_template_versiontogithub-runnersecr-loginconfiguration from user-data.shwhy
libicusolves that requirementecr-loginconfiguration does not support docker login due to PR 315ecr-loginconfiguration cannot use environment credentialsources
github-runnersto explain the most flexibleusage of this component with ECR