Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

account-map Documentation for Dynamic Roles #870

Merged
merged 12 commits into from
Oct 12, 2023
Merged

Conversation

milldr
Copy link
Member

@milldr milldr commented Oct 12, 2023

what

  • Inline documentation for dynamic roles with account-map

why

  • Improved documentation. This file is difficult to follow and hopefully, my notes will be helpful for future developers

references

@milldr milldr requested review from a team as code owners October 12, 2023 02:31
@Nuru Nuru added the no-release Do not create a new release (wait for additional code changes) label Oct 12, 2023
modules/account-map/dynamic-roles.tf Outdated Show resolved Hide resolved
@milldr milldr enabled auto-merge (squash) October 12, 2023 18:15
modules/account-map/dynamic-roles.tf Outdated Show resolved Hide resolved
@milldr milldr merged commit 984db6a into main Oct 12, 2023
3 checks passed
@milldr milldr deleted the account-map-documentation branch October 12, 2023 18:36
goruha pushed a commit to cloudposse-terraform-components/aws-account-map that referenced this pull request Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-release Do not create a new release (wait for additional code changes)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants