-
-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support karpenter-crd
Helm Chart and Fix Node Interruption Handling
#868
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, a few nitpicks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments. Significant changes need to be made to prevent the Kubernetes namespace from being destroyed on configuration changes, and documentation needs to explain how the upgrade path.
Co-authored-by: Nuru <[email protected]>
karpenter-crd
Helm Chart and Revert Docs on Node Interruptionkarpenter-crd
Helm Chart and Fix Node Interruption Handling
|
||
### Upgrading an existing `eks/karpenter` deployment where the `karpenter-crd` chart is already deployed | ||
|
||
If you currently have `eks/karpenter` deployed to an EKS cluster, have upgraded to this version of the component, and already have the `karpenter-crd` chart installed, simply set `var.crd_chart_enabled` to `true` and redeploy Terraform to have Terraform manage the helm release for `karpenter-crd`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you sure you don't have to import the CRD helm chart?
Co-authored-by: Nuru <[email protected]>
…rm-aws-components into support-karpenter-crd
what
karpenter-crd
helm chart alongside thekarpenter
chart with theeks/karpenter
componentiam_policy_statements
with iam_policywhy
karpenter-crd
can be installed alongside thekarpenter
helm chart to automatically manage the lifecycle of Karpenter CRDs.eks/karpenter
was added with Karpenter Node Interruption Handler #713, but documentation was unintentionally removed with Enableterraform plan
access via dynamic Terraform roles #715iam_policy
solves this issue and is the updated patternreferences
karpenter-crd
: https://karpenter.sh/v0.31/upgrade-guide/#custom-resource-definition-crd-upgrades