Add support for redis cluster replication group id definition #1195
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
The Cloudposse elasticache-redis module (https://github.com/cloudposse/terraform-aws-elasticache-redis/blob/main/main.tf#L92) references the ability to define a replication_group_id as a var, but we do not allow for that to be passed through from the reference module and submodule call.
why
In cases where the replication_group_id is not passed, the underlying code will attempt to create one. This can run into naming length limits (aws only allows a limit of 40 characters), so we should provide the ability to override it at all levels.
references