Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for redis cluster replication group id definition #1195

Closed

Conversation

joshAtRula
Copy link

what

The Cloudposse elasticache-redis module (https://github.com/cloudposse/terraform-aws-elasticache-redis/blob/main/main.tf#L92) references the ability to define a replication_group_id as a var, but we do not allow for that to be passed through from the reference module and submodule call.

why

In cases where the replication_group_id is not passed, the underlying code will attempt to create one. This can run into naming length limits (aws only allows a limit of 40 characters), so we should provide the ability to override it at all levels.

references

@joshAtRula joshAtRula requested review from a team as code owners December 11, 2024 15:42
@mergify mergify bot added the triage Needs triage label Dec 11, 2024
@mergify mergify bot closed this Dec 11, 2024
Copy link

mergify bot commented Dec 11, 2024

Warning

Components have moved!

Repository is now read-only
We have migrated every component in this repository to individual repositories under a new GitHub organization.
All future updates, contributions, and issues should be directed to the respective component repositories in the new organization.

Learn more about the migration.

@mergify mergify bot removed the triage Needs triage label Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant