Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos #1121

Closed
wants to merge 2 commits into from
Closed

Fix typos #1121

wants to merge 2 commits into from

Conversation

NathanBaulch
Copy link

Just thought I'd contribute some typo fixes that I stumbled on. Nothing controversial (hopefully).

Use the following command to get a quick summary of the specific corrections made:

git diff HEAD^! --word-diff-regex='\w+' -U0 \
  | grep -E '\[\-.*\-\]\{\+.*\+\}' \
  | sed -r 's/.*\[\-(.*)\-\]\{\+(.*)\+\}.*/\1 \2/' \
  | sort | uniq -c | sort -n

FWIW, the top typos are:

  • admininstrator (22)
  • requestor (18)
  • paramter (9)
  • succeded (8)
  • complated (6)
  • adminstrator (5)
  • refreh (5)
  • creatation (4)
  • terrafrom (4)
  • neeeded (3)
  • subscibres (3)

@NathanBaulch NathanBaulch requested review from a team as code owners October 1, 2024 01:51
Copy link
Member

@goruha goruha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NathanBaulch, thanks for the PR.
Unfortunately, there is too long diff to review.

For now, I'd like to put it on hold.

Your PR changes typos in dependent terraform modules' input names.
That will lead to errors.

CleanShot 2024-10-01 at 14 37 06@2x

I have to close the PR for now.

We are going to split the mono repo to have components per repo and add tests.
Then, tests will highlight all potential failures of that type, and your changes would be welcome.

Thanks.

@goruha goruha closed this Oct 1, 2024
@NathanBaulch
Copy link
Author

NathanBaulch commented Oct 1, 2024

Understandable @goruha, what if I split the PR into breaking (higher risk) vs non-breaking (comments and descriptions only) fixes?
FYI, this PR is about half the size now that #1114 has been merged (209 -> 107 fixes).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants