Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support overriding default origin ID #264

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

mchristopher
Copy link

what

  • Add support for default_origin_id variable, to support custom origin groups on the default behavior.
  • Add optional group_id variable to origin_groups to avoid race conditions when specifying origin groups in behaviors.

why

  • There was no way to activate support for multi-region S3 buckets since origin groups have generated IDs, and you cannot access the id attributes outside of the module code.

references

@mchristopher mchristopher requested review from a team as code owners March 29, 2023 16:49
@mchristopher mchristopher requested review from Gowiem and korenyoni and removed request for a team March 29, 2023 16:49
@hans-d
Copy link

hans-d commented Mar 2, 2024

/terratest

Copy link

mergify bot commented Mar 9, 2024

Thanks @mchristopher for creating this pull request!

A maintainer will review your changes shortly. Please don't be discouraged if it takes a while.

While you wait, make sure to review our contributor guidelines.

Tip

Need help or want to ask for a PR review to be expedited?

Join us on Slack in the #pr-reviews channel.

@mergify mergify bot added the triage Needs triage label Mar 9, 2024
@Gowiem Gowiem added enhancement New feature or request minor New features that do not break anything labels May 10, 2024
@Gowiem
Copy link
Member

Gowiem commented May 10, 2024

/terratest

@Gowiem
Copy link
Member

Gowiem commented May 10, 2024

Hey @mchristopher, unfortunately, we need to run some automation to pass our tests. Mind doing the following locally, adding + committing the result, and pushing to your branch?

make init
make readme

Thanks!

@Gowiem
Copy link
Member

Gowiem commented May 10, 2024

And actually it seems there is some lint errors in this repo overall, would you mind addressing those to move this PR forward?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request minor New features that do not break anything triage Needs triage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants