Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: extend retention period for API Gateway logs #49

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

HectorQuiroz
Copy link

what

This feature allows users to customize the retention period of the logs in CloudWatch.

why

This is useful for users who need to keep logs for longer periods of time for auditing or compliance purposes.

references

#48

@HectorQuiroz HectorQuiroz requested review from a team as code owners August 27, 2024 19:28
@mergify mergify bot added the triage Needs triage label Aug 27, 2024
Copy link

@RoseSecurity RoseSecurity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any way you could run the following to update the docs?

make init
make readme

@RoseSecurity
Copy link

And also add a type? I believe this is an int and not a string

@HectorQuiroz
Copy link
Author

And also add a type? I believe this is an int and not a string

Hello @RoseSecurity ,

The module documentation says that this variable is a string

image

Repository: https://github.com/cloudposse/terraform-aws-cloudwatch-logs
Variable: line 12 -15 https://github.com/cloudposse/terraform-aws-cloudwatch-logs/blob/main/variables.tf

jamengual
jamengual previously approved these changes Sep 23, 2024
Copy link
Contributor

@jamengual jamengual left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks @HectorQuiroz

@mergify mergify bot removed the triage Needs triage label Sep 23, 2024
@HectorQuiroz
Copy link
Author

Is there any way you could run the following to update the docs?

make init
make readme

hey @RoseSecurity ,

I ran make init & make readme to update the documentation. 🚀

@HectorQuiroz
Copy link
Author

LGTM thanks @HectorQuiroz

Thanks @jamengual, I've set the type to be a string as required by tf lint. Can you please approve it again? 💯

@HectorQuiroz
Copy link
Author

And also add a type? I believe this is an int and not a string

Hello @RoseSecurity ,

The module documentation says that this variable is a string

image Repository: https://github.com/cloudposse/terraform-aws-cloudwatch-logs Variable: line 12 -15 https://github.com/cloudposse/terraform-aws-cloudwatch-logs/blob/main/variables.tf

@HectorQuiroz HectorQuiroz reopened this Oct 30, 2024
@mergify mergify bot added triage Needs triage and removed triage Needs triage labels Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage Needs triage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants