Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow role chaining for configuring aws credentials #73

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

mfuhrmeisterDM
Copy link

what

allow to set role chaining for configuring aws credentials

why

We need role chaining because the github runner is already authenticated via web token.

@mfuhrmeisterDM mfuhrmeisterDM requested review from a team as code owners May 6, 2024 12:06
mcalhoun
mcalhoun previously approved these changes May 6, 2024
action.yml Outdated Show resolved Hide resolved
@goruha
Copy link
Member

goruha commented May 6, 2024

@mfuhrmeisterDM could you also update documentation
Add aws-role-chaining: false to README.yaml
https://github.com/cloudposse/github-action-atmos-terraform-plan/blob/main/README.yaml#L67

@mfuhrmeisterDM
Copy link
Author

mfuhrmeisterDM commented May 7, 2024

@mfuhrmeisterDM could you also update documentation Add aws-role-chaining: false to README.yaml https://github.com/cloudposse/github-action-atmos-terraform-plan/blob/main/README.yaml#L67

this is done. I updated also the README.md with make readme but this changed a lot more in the generated file is this by intention?

@nitrocode nitrocode changed the title Allow role chaning for configuring aws credentials Allow role chaining for configuring aws credentials May 8, 2024
Matthias Fuhrmeister added 2 commits July 1, 2024 16:36
use present progressive name

reset credentials for 2nd assume role call if role chaining
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants