Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to GitOps Config File #4

Merged
merged 5 commits into from
Dec 18, 2023
Merged

Move to GitOps Config File #4

merged 5 commits into from
Dec 18, 2023

Conversation

goruha
Copy link
Member

@goruha goruha commented Dec 7, 2023

what

  • Incapsulate configs

Migrating from v1 to v2

v2 drop component-path variable. Now it fetches from atmos.yaml file automatically.

v2 moved variables from inputs to atmos gitops config path ./.github/config/atmos-gitops.yaml

name
atmos-version
atmos-config-path
terraform-state-bucket
terraform-state-table
terraform-state-role
terraform-plan-role
terraform-apply-role
terraform-version
aws-region
enable-infracost

If you want the same behavior in v2 as inv1 you should create config ./.github/config/atmos-gitops.yaml with the same variables as in v1 inputs.

  - name: Remediate Drift
    uses: cloudposse/github-action-atmos-terraform-drift-remediation@v2
    with:
      issue-number: ${{ github.event.issue.number }}
      action: remediate
      atmos-gitops-config-path: ./.github/config/atmos-gitops.yaml  

same behaviour as

  - name: Remediate Drift
    uses: cloudposse/github-action-atmos-terraform-drift-remediation@v1
    with:
      issue-number: ${{ github.event.issue.number }}
      action: remediate
      atmos-config-path: "${{ github.workspace }}/rootfs/usr/local/etc/atmos/"
      terraform-plan-role: "arn:aws:iam::111111111111:role/acme-core-gbl-identity-gitops"
      terraform-state-bucket: "acme-core-ue2-auto-gitops"
      terraform-state-role: "arn:aws:iam::999999999999:role/acme-core-ue2-auto-gitops-gha"
      terraform-state-table: "acme-core-ue2-auto-gitops"
      aws-region: "us-east-2"

@goruha goruha requested review from a team as code owners December 7, 2023 01:48
@goruha goruha requested review from dotCipher and joe-niland and removed request for a team December 7, 2023 01:48
@goruha goruha requested a review from a team as a code owner December 9, 2023 20:32
@goruha goruha changed the title Incupsulate configs Incapsulate configs Dec 9, 2023
Copy link

@dudymas dudymas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks okay, but I'm curious about the versioning.

action.yml Outdated Show resolved Hide resolved
@osterman osterman changed the title Incapsulate configs Move to GitOps Config File Dec 11, 2023
Copy link

@dudymas dudymas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@goruha goruha merged commit 97c4073 into main Dec 18, 2023
1 check passed
@dudymas dudymas deleted the incapsulate-configs branch December 18, 2023 14:16
@dudymas dudymas restored the incapsulate-configs branch December 18, 2023 17:08
@goruha goruha deleted the incapsulate-configs branch January 31, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants