Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace describe-config for atmos-get-setting, add optional cache and azure storage options #62

Merged
merged 15 commits into from
Dec 2, 2024

Conversation

goruha
Copy link
Member

@goruha goruha commented Sep 19, 2024

what

  • Skip AWS auth if Gitops aws configuration empty in atmos settings
  • Updated docs and Tests.
  • Fix: clean environment file from .terraform cache to avoid workspace select errors
  • Replace the describe config for cloudposse/github-action-atmos-get-setting
  • Replace If statements to check for azure repository type
  • Add azure blob storage and cosmos
  • Allow to skip checkout

Why

  • Allow to skip AWS auth and use an external one
  • Make the action cloud agnostic
  • To support azure and better config settings
  • Support stack level integration configs

Example

If atmos.yaml contains

integrations:
  github:
    gitops:
      opentofu-version: 1.7.3    
      terraform-version: 1.5.7
      infracost-enabled: false
      artifact-storage:
        region: us-east-2
        bucket: cptest-core-ue2-auto-gitops
        table: cptest-core-ue2-auto-gitops-plan-storage
# here used to be
#      role: arn:aws:iam::461333128641:role/cptest-core-ue2-auto-gha-iam-gitops-gha
# here used to be
#      role:
#        plan: arn:aws:iam::582055374050:role/cptest-core-gbl-identity-planners
#        apply: arn:aws:iam::582055374050:role/cptest-core-gbl-identity-gitops
      matrix:
        sort-by: .stack_slug
        group-by: .stack_slug | split("-") | [.[0], .[2]] | join("-")

Reference

  • feature/dev-2523-make-aws-role-assumption-optional-in-github-actions

@goruha goruha requested review from a team as code owners September 19, 2024 12:03
@goruha goruha requested a review from a team as a code owner September 19, 2024 15:38
jamengual
jamengual previously approved these changes Oct 17, 2024
@goruha goruha changed the title Skip AWS auth if Gitops aws configuration empty in atmos settings Replace describe-config for atmos-get-setting, add optional cache and azure storage options Dec 2, 2024
@goruha goruha merged commit b48431b into main Dec 2, 2024
10 checks passed
@goruha goruha deleted the aws-auth-optional branch December 2, 2024 18:52
Copy link

github-actions bot commented Dec 2, 2024

These changes were released in v3.0.0.

goruha added a commit to cloudposse/github-action-atmos-terraform-drift-remediation that referenced this pull request Dec 2, 2024
## what

This is based on cloudposse/github-action-atmos-terraform-apply#62

* Pin `cloudposse/github-action-atmos-terraform-apply` action to the latest

## why

To support azure and better config settings

## references
cloudposse/github-action-atmos-terraform-plan#92
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
major Breaking changes (or first stable release)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants