Add README to PR update scope (#79)

* Added README to PR update scope * Added README to PR update scope
cloudposse · Dec 16, 2024 · 7c99e5d · 7c99e5d
1 parent 6d7d813
commit 7c99e5d
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/src/component_updater.py b/src/component_updater.py
@@ -266,9 +266,6 @@ def __does_component_needs_to_be_updated(self, original_component: AtmosComponen
             if updated_file.endswith(COMPONENT_YAML):
                 continue
 
-            if updated_file.endswith(README_EXTENTION):
-                continue
-
             # skip folders
             if not os.path.isfile(updated_file):
                 continue
@@ -279,15 +276,17 @@ def __does_component_needs_to_be_updated(self, original_component: AtmosComponen
             files_to_update.append(relative_path)
             if not os.path.isfile(original_file):
                 logging.info(f"New file: {relative_path}")
-                needs_update = True
+                # Adding *.md file does not require component update, but still should be included into a PR
+                needs_update = needs_update or not relative_path.endswith(README_EXTENTION)
                 continue
 
             if io.calc_file_md5_hash(original_file) != io.calc_file_md5_hash(updated_file):
                 logging.info(f"File changed: {relative_path}")
                 if num_diffs < MAX_NUMBER_OF_DIFF_TO_SHOW:
                     logging.info(f"diff: {self.__tools_manager.diff(original_file, updated_file)}")
                     num_diffs += 1
-                needs_update = True
+                # Adding *.md file does not require component update, but still should be included into a PR
+                needs_update = needs_update or not relative_path.endswith(README_EXTENTION)
 
         for original_file in original_files:
             relative_path = os.path.relpath(original_file, original_component.infra_repo_dir)
@@ -297,7 +296,8 @@ def __does_component_needs_to_be_updated(self, original_component: AtmosComponen
             if os.path.isfile(source_file) and not os.path.isfile(updated_file):
                 logging.info(f"Remove file: {relative_path}")
                 files_to_remove.append(relative_path)
-                needs_update = True
+                # Adding *.md file does not require component update, but still should be included into a PR
+                needs_update = needs_update or not relative_path.endswith(README_EXTENTION)
                 continue
 
         if needs_update:

diff --git a/src/github_provider.py b/src/github_provider.py
@@ -167,7 +167,7 @@ def open_pr(self,
                                               old_source_name=old_source_name,
                                               old_source_link=old_source_link,
                                               new_source_name=new_source_name,
-                                              new_source_link=old_source_link,
+                                              new_source_link=new_source_link,
                                               old_version=original_component.version,
                                               new_version=updated_component.version,
                                               old_version_link=original_component_version_link,