Skip to content

chore(main): fix ai findings#1494

Merged
ArtieReus merged 10 commits intomainfrom
artie-ai-findings-feb
Feb 27, 2026
Merged

chore(main): fix ai findings#1494
ArtieReus merged 10 commits intomainfrom
artie-ai-findings-feb

Conversation

@ArtieReus
Copy link
Collaborator

@ArtieReus ArtieReus commented Feb 27, 2026

Summary

Addressed multiple code quality and maintainability issues identified by GitHub AI code scanning, including accessibility fixes,
deprecated imports, type safety improvements, and error handling.

Changes

  • Accessibility: Corrected spelling of arial-label to aria-label in test description
  • Testing Library: Replaced deprecated act import from React with the recommended import from @testing-library/react
    (React 18+ best practice)
  • Error Handling: Added type guard to check if error is an Error instance before accessing message property, preventing
    potential undefined display to users
  • Type Safety:
    • Replaced any type with proper TypeScript types, defining Props interface with React.ReactNode for children
    • Improved YamlViewerProps to properly type-check spread props by extending base props type

Related Issues

Screenshots (if applicable)

Testing Instructions

  1. pnpm i
  2. pnpm TASK

Checklist

  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • I have made corresponding changes to the documentation (if applicable).
  • My changes generate no new warnings or errors.
  • I have created a changeset for my changes.

PR Manifesto

Review the PR Manifesto for best practises.

@ArtieReus ArtieReus requested review from a team and franzheidl as code owners February 27, 2026 11:18
@ArtieReus ArtieReus self-assigned this Feb 27, 2026
@changeset-bot
Copy link

changeset-bot bot commented Feb 27, 2026

🦋 Changeset detected

Latest commit: 05ba88c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@cloudoperators/juno-app-greenhouse Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Feb 27, 2026

PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-02-27 15:35 UTC

@ArtieReus ArtieReus changed the title Artie ai findings feb chore(main): fix ai findings Feb 27, 2026
edda
edda previously approved these changes Feb 27, 2026
@ArtieReus ArtieReus merged commit 9c81f92 into main Feb 27, 2026
17 checks passed
@ArtieReus ArtieReus deleted the artie-ai-findings-feb branch February 27, 2026 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants