chore(greenhouse): reroute old admin area to new one#1483
chore(greenhouse): reroute old admin area to new one#1483
Conversation
🦋 Changeset detectedLatest commit: 6134c7c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
taymoor89
force-pushed
the
1479-add-link-to-new-admin
branch
from
4bab3d9 to
12ea19f
Compare
ArtieReus
added
the
greenhouse-pr-preview
ArtieReus
left a comment
ArtieReus
left a comment
There was a problem hiding this comment.
very good job!!! just one comment
| // @ts-ignore | ||
| <AppShellProvider theme={`${props.theme ? props.theme : "theme-dark"}`}> | ||
| {/* load styles inside the shadow dom */} | ||
| <style>{styles.toString()}</style> |
There was a problem hiding this comment.
We need to check if the table still working properly without the stiles:
https://github.com/cloudoperators/juno/blob/main/apps/greenhouse/src/components/core-apps/org-admin/components/clusters/styles.css#L11
We could extend the global styles with those in clusters.
There was a problem hiding this comment.
Yes it works because new admin areas is rendered as part of greenhouse not as a separate extension/app which was the case with old admin area. And because greenhouse already has AppShellProvider and these styles, so everything looks good.
There was a problem hiding this comment.
but this stiles are specific to clusters and has scoped styles .clusters
.clusters {
.juno-datagrid-row:hover {
.juno-datagrid-cell {
@apply bg-theme-background-lvl-1;
}
}
.juno-datagrid-row.active {
.juno-datagrid-cell {
@apply bg-theme-background-lvl-2;
}
}
}
Which I don't see in greenhouse:
https://github.com/cloudoperators/juno/blob/main/apps/greenhouse/src/styles.css
Or I am wrong?
There was a problem hiding this comment.
Good point, you are right. But I think these styles are probably redundant and might not need to be copied over to greenhouse, because now DataGridRows supports hover when onClick in supplied. Try to compare old clusters view in QA with this one.
| }) | ||
| return () => { | ||
| if (messageId) { | ||
| removeMessage(messageId) |
3 participants
Summary
This PR replaces old greenhouse admin area with the new one.
Changes Made
/org-adminto/admin(in case someone is already used to of it or has bookmarked/org-admin).org-adminplugin which isn't needed after this change./admin/clusters.Related Issues
Screenshots (if applicable)
2026-02-25_15-43-58.mp4
Testing Instructions
pnpm ipnpm TASKChecklist
PR Manifesto
Review the PR Manifesto for best practises.