Add determine-chunk-shape notebook #31
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
kylebarron
reviewed
Aug 22, 2023
| @@ -0,0 +1,665 @@ | |||
| { | |||
There was a problem hiding this comment.
Line #16. # we can set lon to 2 and lat to 1 since we expect twice as many chunks along the lon dimension as the lat dimension.
Maybe also mention what setting -1 does?
Reply via ReviewNB
| @@ -0,0 +1,665 @@ | |||
| { | |||
There was a problem hiding this comment.
100MB
If direct-to-frontend Zarr visualization ever happens, having such large chunks would be a blocker because the frontend would have to download a minimum of one chunk before anything displays.
Reply via ReviewNB
kylebarron
approved these changes
Aug 22, 2023
|
Thanks for reviewing @kylebarron - headsup I am planning to post this for feedback on pangeo discourse before merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This question comes up so often and I wanted to try out the new method in pangeo-forge/pangeo-forge-recipes#546 that I thought we might add some basic information on how to think about the question of chunk shape and size.