tests: in-memory ldap server runs on a random port #3202
Merged
+84
−107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This will allow tests to run in parallel without having LDAP servers competing for the same port.
Kehrlann
force-pushed
the
dgarnier/test-ldap-random-port
branch
from
e69e4dc to
6abe722
Compare
duanemay
approved these changes
Dec 18, 2024
strehle
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
We want to run tests in parallel on local machines. But there are conflicts with some in-memory LDAP servers trying to bind to the same port.
This PR reworks
InMemoryLdapServerso that it binds to a random port. To make the expected behavior clearer, the server now either listens onldap://ORldaps://, but not both.Notes
ableToConnectToLdapWithInvalidSsl_WithSkipValidationInMemoryLdapServer#startLdap()InMemoryLdapServer#startLdapWithTls(keystore)server.getUrl()