deps: remove code dependencies on hsqldb #3194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Kehrlann is this the fix for the issue, that unit tests run against wrong DB =? Sonar has an issue , not with your PR, but maybe you can add also autowired to solve btw. do you see the sonar findings ? |
strehle
approved these changes
Dec 12, 2024
coolgang123
approved these changes
Dec 12, 2024
duanemay
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are code dependencies on
hsqldb. As part of gh-3186 , we are trying to ensure that tests are run against the correct database.This code removes explicit code dependencies on
hsqldb, without removing the dependency import.It makes it easy to completely remove the
hsqldbdependency when we are debugging databases and profiles, and ensure that HSQL is never used when we target postgres or mysql.