Code cleanup

[duanemay]

Mostly automated with Openrewrite rules, and some manual updates.

Rules Run: CodeStyle, Common Static Analysis Issue remediation, Java 17

[strehle]

can you please check these 7 findings about
!!

https://sonarcloud.io/project/issues?severities=BLOCKER%2CCRITICAL%2CMAJOR%2CMINOR&sinceLeakPeriod=true&issueStatuses=OPEN%2CCONFIRMED&types=BUG&pullRequest=3174&id=cloudfoundry-identity-parent

[strehle]

Please resolve with develop

[strehle]

@duanemay So far I am through with, thanks for the cleanup. I have 2 open clarifications

1. The test coverage is low because some objects from IdP removal ( see Remove SAML IDP feature #2638 , reason of major upgrade to 77.x ) still there. Suggest to remove these objects with an extra PR, WDYT ?

2. Guava. Should we remove Guava from usage at all ? Because right now you removed the direct dependency only but then we get Guava from the transient dependency from opensaml 4.x . We can exclude it in general but then also some other classes still use Util functions from Guava. Problem now: transient dependency adds Guava 28.x which has some CVEs. With that package we run into a problem with our validation

[strehle]

@duanemay So far I am through with, thanks for the cleanup. I have 2 open clarifications

1. The test coverage is low because some objects from IdP removal ( see Remove SAML IDP feature #2638 , reason of major upgrade to 77.x ) still there. Suggest to remove these objects with an extra PR, WDYT ?

Tested without guava and yes,
net.shibboleth.utilities.java.support.xml.BasicParserPool.setBuilderFeatures
needs it, so we cannot omit but then it is better we define the version of used guava and use the lastest. Otherwise we get an outdated version if we rely on transitive deps.