Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: change sonar runner to java 17 #2513

Merged
merged 3 commits into from
Oct 4, 2023
Merged

build: change sonar runner to java 17 #2513

merged 3 commits into from
Oct 4, 2023

Conversation

strehle
Copy link
Member

@strehle strehle commented Oct 1, 2023 •
edited
Loading

@cf-gitbot
Copy link

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/186157021

The labels on this github issue will be updated when the story is started.

@strehle strehle added dependencies Pull requests that update a dependency file java Pull requests that update Java code github_actions Pull requests that update GitHub Actions code labels Oct 1, 2023
@peterhaochen47
Copy link
Member

Hi @strehle, is this just a preliminary test to see if UAA can be upgraded to using Java 17?

@strehle
Copy link
Member Author

strehle commented Oct 3, 2023

uaa can be upgraded, because we have a github action already, see
https://github.com/cloudfoundry/uaa/blob/develop/.github/workflows/gradle.yml#L19
or run
https://github.com/cloudfoundry/uaa/actions/workflows/gradle.yml

So this is simply to switch sonar to 17 to follow the warnings which are there in current runs, means sonar wants to have now 17.

Most github actions here depend on docker images, so the switch is done if you change the image

bruce-ricard
bruce-ricard approved these changes Oct 3, 2023
View reviewed changes
Copy link
Contributor

@bruce-ricard bruce-ricard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me. 👍

@strehle strehle merged commit bf51726 into develop Oct 4, 2023
18 checks passed
@strehle strehle deleted the sonar-17 branch October 4, 2023 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bruce-ricard bruce-ricard bruce-ricard approved these changes

Assignees
No one assigned
Labels
accepted Accepted the issue dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code java Pull requests that update Java code
Projects
Foundational Infrastructure Working Group
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@strehle @cf-gitbot @peterhaochen47 @bruce-ricard