Upgrade to be compatible with simplesamlphp v2 #2506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Better not to depend on what it looks like - consider making this more generic later. Authored-by: Danny Faught <[email protected]>
Authored-by: Danny Faught <[email protected]>
* Generally better to use an ID anyway. Authored-by: Danny Faught <[email protected]>
Co-authored-by: Peter Chen <[email protected]>
* Make the test less fragile in general. Co-authored-by: Peter Chen <[email protected]>
[#185279615] Co-authored-by: Danny Faught <[email protected]>
- Unlike other tests where UAA obtains the SAML metadata xml with an URL, this test uses a locally defined static SAML metadata xml value (in order to simulate a test case where the "SingleLogoutService" entry inside the SAML metadata xml is absent), which needs to be updated to match the new simplesaml server. - This also fixes testSingleLogoutWithLogoutRedirect test for the same reason. [#185279615] Co-authored-by: Hongchol Sinn <[email protected]>
* This is the last failing test in this class needed to be fixed related to the simplesaml upgrade. Co-authored-by: Peter Chen <[email protected]>
* Already fixed in one place, these are the other copypastas of the same thing. Co-authored-by: Peter Chen <[email protected]>
* And remove TODOs. * Missing cert error fixed in a config change in the simplesamlphp source. Co-authored-by: Peter Chen <[email protected]>
- to accomodate to simplesaml server v2's UI changes [#185279615]
* That server is currently deployed * This change is to ensure that the tests will not be failing when we push, because they would be running against the old v1 server * This change should be reverted after we have pushed the new saml v2 server to use the old http://simplesamlphp.uaa-acceptance.cf-app.com URL Signed-off-by: Bruce Ricard <[email protected]>
|
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/186136022 The labels on this github issue will be updated when the story is started. |
bruce-ricard
commented
Sep 27, 2023
| @@ -86,10 +86,10 @@ | |||
|
|
|||
| public class IntegrationTestUtils { | |||
|
|
|||
| public static final String SIMPLESAMLPHP_UAA_ACCEPTANCE = "http://simplesamlphp.uaa-acceptance.cf-app.com"; | |||
| public static final String SIMPLESAMLPHP_UAA_ACCEPTANCE = "http://simplesamlphp2.uaa-acceptance.cf-app.com"; | |||
There was a problem hiding this comment.
Not to break the tests when we merge and the tests run on CI, we temporarily changed the URL to point towards the already deployed v2 saml server. We'll revert this after we have deployed the new v2 server to the old URL.
strehle
approved these changes
Sep 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Luckily, we only needed to update tests.
Context:
cf-deploymentonly supportcflinuxfs4stemcells.cf pushed to CF, and is only compatible withcflinuxfs3stemcells.cflinuxfs4, so we decided that we need to start using it instead of the old v1 one.