Passcode test refactor #2501
Merged
Passcode test refactor #2501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swalchemist
requested review from
Tallicia,
bruce-ricard,
strehle,
peterhaochen47,
tack-sap and
hsinn0
|
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/186117819 The labels on this github issue will be updated when the story is started. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This applies the page object strategy to the testSimpleSamlPhpPasscodeRedirect test. This required using a factory method to start the interaction on the passcode page that immediately redirects to the login page (requestPasscode_goToLoginPage) because the pattern I'm using here is that a constructor will expect it to land on the passcode page.
Also included a bit of code improvement in the page objects.