Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: support jwt client configuration #93

Merged
merged 1 commit into from
Oct 17, 2023
Merged

Conversation

strehle
Copy link
Member

@strehle strehle commented Oct 11, 2023

allow to set JWKS configuration for client authentication based on private_key_jwt standard

allow to set JWKS configuration for client authentication based on private_key_jwt standard
@cf-gitbot
Copy link

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/186231409

The labels on this github issue will be updated when the story is started.

@strehle strehle requested review from a team, Tallicia and torsten-sap October 13, 2023 05:33
@strehle
Copy link
Member Author

strehle commented Oct 13, 2023

this PR belongs to the private_key_jwt story and is an enhancement to allow setting a trust for jwt client authentication
@Tallicia can you please decide if you want do a review from vmware side and how should do it, thanks

@Tallicia
Copy link

Hi @strehle - Yes we would like to review. Do you have a summary and or spec this is targeting so that we can validate this aligns to the intent?

@bruce-ricard or @hsinn0 would you like to take a look at this?

@strehle
Copy link
Member Author

strehle commented Oct 13, 2023

Hi @strehle - Yes we would like to review. Do you have a summary and or spec this is targeting so that we can validate this aligns to the intent?

@bruce-ricard or @hsinn0 would you like to take a look at this?

Sure, the related PR from UAA is cloudfoundry/uaa#2449 . This explains the API.
See:
https://docs.cloudfoundry.org/api/uaa/version/76.22.0/index.html#change-client-jwt

The uaac change is cloudfoundry/cf-uaac#125

So finally the feature is to maintain the new client jwt trust. If trust is there a Openid connect client can use it.
Private_key_jwt is a common way, therefore if a uaa client hat jwt trust, you can use standard spring security in a test app, e.g.
https://github.com/strehle/spring-openid-client/blob/main/src/main/resources/application.yml

@strehle strehle merged commit 93bac69 into master Oct 17, 2023
6 checks passed
@strehle strehle deleted the change_clientjwt branch October 17, 2023 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

4 participants