-
Notifications
You must be signed in to change notification settings - Fork 709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
try to improve vitest-pool-workers for the cjs module resolution #6661
base: main
Are you sure you want to change the base?
Conversation
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10795534377/npm-package-wrangler-6661 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6661/npm-package-wrangler-6661 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10795534377/npm-package-wrangler-6661 dev path/to/script.js Additional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10795534377/npm-package-create-cloudflare-6661 --no-auto-update npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10795534377/npm-package-cloudflare-kv-asset-handler-6661 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10795534377/npm-package-miniflare-6661 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10795534377/npm-package-cloudflare-pages-shared-6661 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10795534377/npm-package-cloudflare-vitest-pool-workers-6661 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10795534377/npm-package-cloudflare-workers-editor-shared-6661 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10795534377/npm-package-cloudflare-workers-shared-6661 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
2a5e992
to
6ab171c
Compare
6ab171c
to
f70344b
Compare
6b748ea
to
20d5261
Compare
5344a05
to
69e7515
Compare
This reverts commit 69e7515.
Assigning to @penalosa as we discussed, he should be well positioned to debug the windows incompatibility/failure 🙂 |
What this PR solves / how to test
Fixes #6591
Author has addressed the following