Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

try to improve vitest-pool-workers for the cjs module resolution #6661

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

dario-piotrowicz
Copy link
Member

@dario-piotrowicz dario-piotrowicz commented Sep 9, 2024

What this PR solves / how to test

Fixes #6591

Author has addressed the following

  • Tests
    • TODO (before merge)
    • Included
    • Not necessary because:
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required / Maybe required
    • Not required because:
  • Changeset (Changeset guidelines)
    • TODO (before merge)
    • Included
    • Not necessary because:
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Not necessary because:

Copy link

changeset-bot bot commented Sep 9, 2024

⚠️ No Changeset found

Latest commit: 7a3f08c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Sep 9, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10795534377/npm-package-wrangler-6661

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6661/npm-package-wrangler-6661

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10795534377/npm-package-wrangler-6661 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10795534377/npm-package-create-cloudflare-6661 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10795534377/npm-package-cloudflare-kv-asset-handler-6661
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10795534377/npm-package-miniflare-6661
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10795534377/npm-package-cloudflare-pages-shared-6661
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10795534377/npm-package-cloudflare-vitest-pool-workers-6661
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10795534377/npm-package-cloudflare-workers-editor-shared-6661
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10795534377/npm-package-cloudflare-workers-shared-6661

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240821.1
workerd 1.20240821.1 1.20240821.1
workerd --version 1.20240821.1 2024-08-21

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@dario-piotrowicz dario-piotrowicz force-pushed the vitest-pool-workers-enhanced-resolve branch 2 times, most recently from 2a5e992 to 6ab171c Compare September 9, 2024 23:05
@dario-piotrowicz dario-piotrowicz force-pushed the vitest-pool-workers-enhanced-resolve branch from 6ab171c to f70344b Compare September 10, 2024 10:28
@dario-piotrowicz dario-piotrowicz force-pushed the vitest-pool-workers-enhanced-resolve branch from 6b748ea to 20d5261 Compare September 10, 2024 11:33
@dario-piotrowicz dario-piotrowicz changed the title try to use enchanced-resolve in vitest-pool-workers for the cjs module resolution try to improve vitest-pool-workers for the cjs module resolution Sep 10, 2024
@dario-piotrowicz dario-piotrowicz force-pushed the vitest-pool-workers-enhanced-resolve branch from 5344a05 to 69e7515 Compare September 10, 2024 14:17
@dario-piotrowicz
Copy link
Member Author

Assigning to @penalosa as we discussed, he should be well positioned to debug the windows incompatibility/failure 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Untriaged
Development

Successfully merging this pull request may close these issues.

🐛 BUG: vitest-pool-workers doesn't correctly resolve required modules if no extension is provided
2 participants