add gc support to Rust owned objects #5638
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anonrig
requested review from
guybedford,
harrishancock,
jasnell,
kentonv and
mikea
anonrig
force-pushed
the
yagiz/rust-gc
branch
from
0f0adb0 to
fa9ad80
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
guybedford
reviewed
Dec 8, 2025
| /// When a resource is wrapped for JavaScript, `State` stores a strong V8 Global handle to the | ||
| /// wrapper object. The `strong_ref_count` tracks how many Rust `Ref<R>` handles exist. When the | ||
| /// count reaches zero and a wrapper exists, the Global is made weak so V8 can garbage collect | ||
| /// the wrapper and trigger cleanup via the weak callback. |
| } | ||
| } | ||
|
|
||
| pub fn unwrap<'a, R: Resource>(lock: &'a mut Lock, value: v8::Local<v8::Value>) -> &'a mut R { |
Contributor
There was a problem hiding this comment.
It's a bit of a concern from a Rust perspective if you can obtain multiple mutable borrows this way, should we protect against that case?
|
|
||
| impl<T: Resource> DerefMut for Ref<T> { | ||
| fn deref_mut(&mut self) -> &mut Self::Target { | ||
| unsafe { &mut (*self.instance).resource } |
Contributor
There was a problem hiding this comment.
It seems like this permits multiple mut refs to the same data, do we need to consider protections?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds garbage collection support to Rust-owned JSG resources, enabling proper cleanup when V8 collects JavaScript wrapper objects.