Run V8's code formatter on patches. #5632
Open
+11
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harrishancock
approved these changes
Dec 3, 2025
This comment was marked as outdated.
This comment was marked as outdated.
jasnell
approved these changes
Dec 3, 2025
Collaborator
|
Might be good to add this as a step in the v8.md/v8-updates.md docs in both this and the internal repo as a reminder |
anonrig
approved these changes
Dec 3, 2025
Collaborator
|
to address the CI failure here: #5635 |
Collaborator
|
If you rebase from |
erikcorry
force-pushed
the
erikcorry/git-cl-format
branch
from
f96d0f3 to
fbd4302
Compare
anonrig
approved these changes
Dec 4, 2025
V8 uses 'git cl format' to autoformat C++ and other languages. It's easier to work with our patches if they are also formatted this way.
erikcorry
force-pushed
the
erikcorry/git-cl-format
branch
from
fbd4302 to
10deaab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
V8 uses 'git cl format' to autoformat C++ and other languages. It's easier to work with our patches if they are also formatted this way.