R2-3560: Implement ListParts and ListMultipartUploads for R2 Binding
#5596
+221,732
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Schachte
reviewed
Nov 27, 2025
helloimalastair
force-pushed
the
list-binding-r2
branch
from
586c50e to
c1ecf41
Compare
helloimalastair
force-pushed
the
list-binding-r2
branch
from
c1ecf41 to
8bb7131
Compare
7 tasks
- Add range validation (1-1000) for `limit` parameter in `listMultipartUploads` - Change default limit from 0xffffffff to 0x3e8 (1000) in R2ListMultipartUploadsRequest - Fix `partNumberMarker` validation to require positive values (p > 0) instead of non-negative (p >= 0) - Fix `listParts` to pass JWT authentication token to doR2HTTPGetRequest
helloimalastair
force-pushed
the
list-binding-r2
branch
from
8bb7131 to
c722755
Compare
jasnell
reviewed
Dec 10, 2025
| KJ_IF_SOME(o, options) { | ||
| KJ_IF_SOME(l, o.limit) { | ||
| JSG_REQUIRE(l >= 1 && l <= 1000, RangeError, | ||
| "limit must be between 1 and 1000 (inclusive). Actual value was: ", l); |
Collaborator
There was a problem hiding this comment.
Is this a new requirement? Would this cause a new error to be thrown? If so, this might need a compat flag. If the code already errored here or this previously didn't work, then that might not be necessary.
jasnell
reviewed
Dec 10, 2025
|
|
||
| KJ_IF_SOME(o, options) { | ||
| KJ_IF_SOME(l, o.limit) { | ||
| JSG_REQUIRE(l >= 1 && l <= 1000, RangeError, |
Collaborator
There was a problem hiding this comment.
Consider moving the 1000 to a constant.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should be released in tandem with cloudflare/workers-sdk#11562.