handle hashtags in statuses #348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dario-piotrowicz
force-pushed
the
hastags
branch
from
9e0ee92
to
b2096ed
Compare
xtuc
reviewed
Feb 28, 2023
|
|
||
| const getLinkAnchorPlaceholder = (link: string) => { | ||
| const anchor = getLinkAnchor(link) | ||
| const placeholder = `%%%___-LINK-PLACEHOLDER-${crypto.randomUUID()}-__%%%` |
There was a problem hiding this comment.
because you can have # in urls (for pages' fragments) like so for example:
wildebeest/backend/test/mastodon.spec.ts
Line 189 in efdf8ee
so I am using the placeholders to completely remove the links temporarily, apply the hashtags replacement and then I put back the links when it is ok to do so.
Alternatively I could have changed the hashtag replacement code to be smarter and check that the hashtag is not part of a url, but I felt like that could become quite complex and error prone, so I thought I could just use this placeholder strategy instead
what do you think?
- by parsing them in enrichStatus - implementing a tag page to show their timeline resolves #345
dario-piotrowicz
force-pushed
the
hastags
branch
from
b2096ed
to
a606e76
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #345